pydrake: Add bindings for common.schema #14014
Conversation
|
+@ggould-tri for review, please. |
|
a discussion (no related file): |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)
bindings/pydrake/common/schema_py.cc, line 113 at r1 (raw file):
// values. In the future, we should also bind Size == 1 through Size == 6 // (to match the C++ code). When we do that, we'll replace the suffix X with // the template pattern `_[Size]`, e.g., `DeterministicVector[3]`.
minor: Did you mean to have an underscore in the e.g. text?
common/schema/transform.h, line 189 at r1 (raw file):
/// Samples this Transform. If this is deterministic, the result is the same /// as GetDeterministicValue. math::RigidTransformd Sample(RandomGenerator* generator) const;
BTW thanks for the reminder I need to do this in my stochastic sink code.
jwnimmer-tri
force-pushed
the
schema-pybind
branch
from
b873ee2
to
b2f7845
Compare
|
a discussion (no related file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Done. |
This only binds the variable-sized stochastic vector types. The fixed-size stochastic vector type are not yet available.
jwnimmer-tri
force-pushed
the
schema-pybind
branch
from
b2f7845
to
05a4556
Compare
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers (waiting on @ggould-tri)
bindings/pydrake/common/schema_py.cc, line 113 at r1 (raw file):
Previously, ggould-tri wrote…
minor: Did you mean to have an underscore in the e.g. text?
Why not both? I was debating which name was best, and I don't know yet. I've noted both options.
There was a problem hiding this comment.
+@sammy-tri for platform review
Reviewable status: LGTM missing from assignees ggould-tri(platform),sammy-tri(platform) (waiting on @ggould-tri and @sammy-tri)
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 3 of 3 files at r2.
Reviewable status: LGTM missing from assignee ggould-tri(platform), labeled "do not merge"
|
I think the missing LGTM from @ggould-tri was an oversight. If there's more to do, let me know and I'll follow up. |
jwnimmer-tri
added
status: single reviewer ok
|
|
This only binds the variable-sized stochastic vector types.
The fixed-size stochastic vector type are not yet available.
Towards #13251.
This change is